Docutils: Documentation Utilities / Bugs / #338 smartquotes: re.sub() with misplaced flags

#338 smartquotes: re.sub() with misplaced flags

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2020-03-03

Created: 2018-01-08

Creator: Jakub Wilk

Private: No

docutils/utils/smartquotes.py contains the following statement:

text = re.sub(r"""'(?=\d{2}s)""", smart.apostrophe, text, re.UNICODE)

But the 4th argument to re.sub() is supposed to be maximum number of substitutions, not flags.

This bug was found using pydiatra.

Discussion

Günter Milde - 2018-01-09

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Günter Milde - 2018-01-09

Fixed in commit 8209.
Thank you for the report

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jakub Wilk - 2018-01-13

I forgot to mention that in Python 2.6 (which Docutils is supposed to support), re.sub() doesn't accept flags argument at all. You would have to compile the regexp beforhand, or use inline flags.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Günter Milde - 2018-01-15
  
  You are right, I missed this point.
  As the Unicode flag is not required in this specific expression, I removed it to restore 2.6 compatibility.
  Thank you for reporting.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.