#2 Incorrect Grammar

[Nigel Jewell]

Hi,

I've just been having a play with your docsis code ...
decoding and recoding a few samples. Anyway - I
noticed that trying to assigned a negative integer
fails. Having a look at docsis_lex.l, T_INTEGER is
defined as:

[0-9]+ { yylval.intva ...

I suspect it should be:

-?[0-9]+ { yylval.intva ...

Nige.

[Cornel Ciocirlan]

Logged In: YES
user_id=44570

What exactly are you trying to assign a negative integer
to ? AFAIK all DOCSIS configuration settings are positive
(unsigned) integers, that's why it only accepts
integers ... Maybe I'm missing something ?

[Nigel Jewell]

Logged In: YES
user_id=329211

Ahh - okay, fair point ...

I've decoded a file thats resulting in negative numbers, and
I was just trying to encode it again (before I started
changing anything). Obviously I remove all of the
unnecessaries first ... could the decoder be at fault?

Sorry if I've missed the point - only guessing ... maybe I'm
totally off-beam ;).

Nige.

[Cornel Ciocirlan]

Logged In: YES
user_id=44570

Can you send me the file via E-mail ? It's probably a bug
in the decoder :).