Review request: PR #54 — Windows onboarding crash fix (encode-safe CLI output)
Your AI's guard dog to stop it from going rogue.
Brought to you by:
doberman
Menu
▾
▴
#55 Review request: PR #54 — Windows onboarding crash fix (encode-safe CLI output)
Originally created by: fu351
PR [#54] is ready for review + merge — it is fu351's own PR, so per our no-self-merge rule a peer reviews and lands it. @Tian-Tan / @Bestpart-Irene.
Found while dogfooding Doberman on Windows: doberman install-hooks / setup crash with UnicodeEncodeError on the default cp1252 console (they print → / box-drawing via typer.echo). This blocks onboarding for any such user.
Fix (two layers): an entry-point _ensure_encode_safe_stdio() (reconfigure stdout/stderr to UTF-8 + errors="replace") so output can never crash on the console encoding; plus ASCII-ifying the decorative onboarding strings so they render cleanly everywhere. Tests cover the cp1252-crash guard + ASCII/cp1252-encodable onboarding output. Standalone fix off main (not stacked).
Please review + merge if good.
Related
Ticket changed by: fu351
Originally posted by: fu351
Closing as resolved: PR [#54] (encode-safe CLI output for the Windows onboarding crash) was merged to main on 2026-06-29 (merge commit d10b464). This review-request issue is now obsolete.
Related
Tickets:
#54