Menu

#468 test: cover data-class non-detections

closed
nobody
None
2026-08-28
2026-08-26
Anonymous
No

Originally created by: slegarraga

Closes [#405]

What

  • Adds regression coverage for the data-class rule's documented OTP limit: a six-digit code bound for an external destination stays PASS.
  • Adds coverage for an undashed SSA-valid SSN staying PASS, using the same digits as the valid dashed test value to prove detection depends on shape.
  • Groups both cases under a documented non-detections section beside the existing precision tests.

Verification

  • .venv/bin/pytest tests/unit/test_rule_data_classes.py -q — 16 passed.
  • .venv/bin/ruff check tests/unit/test_rule_data_classes.py — passed.
  • .venv/bin/ruff format --check tests/unit/test_rule_data_classes.py — passed.
  • git diff --check — clean.

Related

Tickets: #405
Tickets: #495
Tickets: #509

Discussion

  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: closed --> open
     
  • Anonymous

    Anonymous - 2026-08-28

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-28

    Originally posted by: fu351

    Merged, thanks @slegarraga! Reusing the nine digits of SSN_VALID for the undashed case is the part I like most, it pins the rule to the dashed shape rather than to the value, so a pattern change that starts matching bare digit runs goes red immediately.

     

Log in to post a comment.