Menu

#228 docs: remove nonexistent doberman taint verb from SETUP.md

closed
nobody
None
2026-08-03
2026-08-02
Anonymous
No

Originally created by: AshSgDe29071999

Summary

SETUP.md listed taint among posture-/auth-mutating Doberman verbs blocked as control-plane tampering. There is no doberman taint command — only a read-only taint surface inside status.

Drop taint from that verb list so the security docs match the CLI. Guardrail code and tests are intentionally untouched.

Fixes [#224]

Related

Tickets: #224
Tickets: #230

Discussion

  • Anonymous

    Anonymous - 2026-08-03

    Originally posted by: fu351

    Reviewed against the CLI rather than the description, and the claim holds: doberman taint does not exist. The command tree is serve, scan, review, mode, enforcement, prefs, status, doctor, revoke, log, tui, dash, demo, memory, policy-history, install-hooks, uninstall-hooks, setup, dashboard, version, plus the 2fa / password / hook sub-apps. The read-only taint surface you point at is real and sits in status (src/doberman/cli/main.py:508-512). Every verb left in that sentence still mutates posture or auth state, so the list is accurate after the edit.

    What I want to call out is what you didn't touch. taint is still in _DOBERMAN_CONTROL_SUBCOMMANDS (src/doberman/engine/rules/commands.py:56-67) and still referenced at tests/unit/test_rule_commands_control_plane.py:186. At a glance both look like the same bug. They aren't: blocking a verb that doesn't exist is harmless and fails closed, and changing a guardrail's blocking set is a different decision from correcting a docs sentence. The issue carved that out, you read the carve-out, and you shipped one line in one file. Scope discipline around security-adjacent code is the harder half of working in this repo and it's what most first PRs get wrong.

    CI is green across all five checks.

     
  • Anonymous

    Anonymous - 2026-08-03

    Ticket changed by: fu351

    • status: open --> closed
     

Log in to post a comment.