|
From: Seiji A. <sei...@hd...> - 2013-02-19 21:01:40
|
OK. I will update my patch.
Seiji
> -----Original Message-----
> From: Steven Rostedt [mailto:ro...@go...]
> Sent: Tuesday, February 19, 2013 1:41 PM
> To: H. Peter Anvin
> Cc: Seiji Aguchi; x8...@ke...; lin...@vg...; Thomas Gleixner (tg...@li...); 'mi...@el...'
> (mi...@el...); Borislav Petkov (bp...@al...); Satoru Moriya; dle...@li...; lin...@vg...;
> Luck, Tony (ton...@in...)
> Subject: Re: [PATCH v9 2/3] trace,x86: add x86 irq vector tracepoints
>
> On Mon, 2013-02-18 at 20:39 -0800, H. Peter Anvin wrote:
>
> > > static void switch_to_trace_idt(void *arg) {
> > > load_idt(&trace_idt_descr);
> > > }
> > >
> > > static void restore_original_idt(void *arg) {
> > > load_idt(this_cpu_ptr(&idt_descr));
> > > }
> > >
> >
> > Yes. If there needs to be handshaking about whose IDT is currently
> > installed I'm much happier if that handshake is done explicitly,
> > rather than as a save/restore function which will break when we have
> > to add another one which for whatever reason isn't nesting.
>
> Agreed.
>
> Seiji, can you make the update?
>
> Thanks,
>
> -- Steve
>
|