Re: [Dle-develop] [RFC][PATCH v2 0/3] efi_pstore: avoid losing critical message

[Matthew G. <mj...@re...>]

On Thu, Jul 19, 2012 at 09:11:44PM +0000, Seiji Aguchi wrote:

> [Patch Descriptions]
>  Patch 1/3 and 2/3 take fist approach, _not_ overwriting entries.
> 
>  Patch 3/3 takes second approach, adding some logic overwriting entries.
> 
>  1/3: Avoid overwriting existing entry
>   This patch just avoid overwriting entries to save the 1st critical message 
>   without being influenced by subsequent events.

I think there's a good argument in favour of this approach. Userspace 
crash report tools should be taught to copy the crash data and then 
remove the existing entries. It avoids any of the complexity associated 
with other approaches and ensures that behaviour is always consistent.

-- 
Matthew Garrett | mj...@sr...