Re: [Dle-develop] [PATCH -tip v3&10 02/18] kprobes: Introduce generic insn_slot framework

[Masami H. <mhi...@re...>]

Mathieu Desnoyers wrote:
> * Masami Hiramatsu (mhi...@re...) wrote:
>> Make insn_slot framework support various size slots.
>> Current insn_slot just supports one-size instruction buffer slot. However,
>> kprobes jump optimization needs larger size buffers.
> 
> OK, so you end up having one insn slot cache for kprobes and one insn
> slot (eventually) for the static jump patching (which needs larger
> instruction slots than kprobes). That seems like a good way to ensure
> you do not use more memory than necessary.
> 
> We could possibly go even further and automatically use the right insn
> slot cache given the size of the instruction entry that must be added (a
> bit like the memory allocator which have different pools for each
> allocation order).

Sure, that will be simpler interface.

> Possibly that using the terminology of "memory pools" rather than
> "cache" could be a better fit too. So what this really becomes is an
> instruction slot allocator and garbage collector.

Ah, right. It would be better to rename kprobe_insn_pool() :)

Thank you,



-- 
Masami Hiramatsu
e-mail: mhi...@re...