Re: [Dle-develop] [PATCH tracing/kprobes v3 6/7] perf: Add perf probe subcommand for kprobe-event setup helper

[Frederic W. <fwe...@gm...>]

On Thu, Oct 08, 2009 at 05:17:34PM -0400, Masami Hiramatsu wrote:
> Masami Hiramatsu wrote:
>> Add perf probe subcommand for kprobe-event setup helper to perf command.
>> This allows user to define kprobe events by C expressions (C line numbers,
>> C function names, and C local variables).
>>
>> Usage
>> -----
>>   perf probe [<options>] -P 'PROBEDEF' [-P 'PROBEDEF' ...]
>>
>>      -k, --vmlinux<file>   vmlinux/module pathname
>>      -P, --probe<p|r:[GRP/]NAME FUNC[+OFFS][@SRC]|@SRC:LINE [ARG ...]>
>>                            probe point definition, where
>> 		p:	kprobe probe
>> 		r:	kretprobe probe
>> 		GRP:	Group name (optional)
>> 		NAME:	Event name
>> 		FUNC:	Function name
>> 		OFFS:	Offset from function entry (in byte)
>> 		SRC:	Source code path
>> 		LINE:	Line number
>> 		ARG:	Probe argument (local variable name or
>> 			kprobe-tracer argument format is supported.)
>
> Oops, I found it caused compilation error on gcc < 4.4 as below:
>
>     CC builtin-trace.o
>     CC builtin-probe.o
> cc1: warnings being treated as errors
> builtin-probe.c: In function 'parse_probepoint':
> builtin-probe.c:109: error: implicit declaration of function 'strndup'
> builtin-probe.c:109: error: incompatible implicit declaration of built-in function 'strndup'
>
> Since I forgot to add _GNU_SOURCE...
>


No problem, I can add it, or rather include util/util.h as it includes
everything necessary for the string functions + _GNU_SOURCE :)