Re: [Dle-develop] [RFC][ PATCH -tip v2 3/7] Kbuild: disable gcc crossjumping

[Steven R. <ro...@go...>]

A change like this requires an ACK from Sam Ravnborg.

-- Steve



On Mon, 22 Jun 2009, Masami Hiramatsu wrote:

> Add CONFIG_DISABLE_CROSSJUMP option which disables gcc's cross-function
> jumping. This option is required by the kprobes jump optimization.
> 
> Signed-off-by: Masami Hiramatsu <mhi...@re...>
> Cc: Ananth N Mavinakayanahalli <an...@in...>
> Cc: Ingo Molnar <mi...@el...>
> Cc: Jim Keniston <jke...@us...>
> Cc: Srikar Dronamraju <sr...@li...>
> Cc: Christoph Hellwig <hc...@in...>
> Cc: Steven Rostedt <ro...@go...>
> Cc: Frederic Weisbecker <fwe...@gm...>
> Cc: H. Peter Anvin <hp...@zy...>
> Cc: Anders Kaseorg <an...@ks...>
> Cc: Tim Abbott <ta...@ks...>
> ---
> 
>  Makefile          |    4 ++++
>  lib/Kconfig.debug |    7 +++++++
>  2 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 2903e13..f73b139 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -524,6 +524,10 @@ else
>  KBUILD_CFLAGS	+= -O2
>  endif
>  
> +ifdef CONFIG_DISABLE_CROSSJUMP
> +KBUILD_CFLAGS	+= -fno-crossjumping
> +endif
> +
>  include $(srctree)/arch/$(SRCARCH)/Makefile
>  
>  ifneq ($(CONFIG_FRAME_WARN),0)
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8da7467..f88e6b8 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -673,6 +673,13 @@ config FRAME_POINTER
>  	  larger and slower, but it gives very useful debugging information
>  	  in case of kernel bugs. (precise oopses/stacktraces/warnings)
>  
> +config DISABLE_CROSSJUMP
> +	bool "Disable cross-function jump optimization"
> +	help
> +	  This build option disables cross-function jump optimization
> +	  (crossjumping) of gcc. Disabling crossjumping might increase
> +	  kernel binary size a little.
> +
>  config BOOT_PRINTK_DELAY
>  	bool "Delay each boot printk message by N milliseconds"
>  	depends on DEBUG_KERNEL && PRINTK && GENERIC_CALIBRATE_DELAY
> 
> 
> -- 
> Masami Hiramatsu
> 
> Software Engineer
> Hitachi Computer Products (America), Inc.
> Software Solutions Division
> 
> e-mail: mhi...@re...
>