#37 problem verifying a broken signature with an empty q tag

[Jason Long]

Jason,

Thanks for releasing the Mail::DKIM 0.38, looks good!

Some nitpicks, found by greping our log:

two warnings:

Apr 6 17:26:56 dorothy amavis[90842]: (90842-01) _WARN:
Use of uninitialized value $query_type in lc
at /usr/local/lib/perl5/site_perl/5.12.0/Mail/DKIM/PublicKey.pm line 86,
<GEN28> line 26.

Apr 6 17:26:56 dorothy amavis[90842]: (90842-01) _WARN:
Use of uninitialized value $query_type in concatenation (.) or string
at /usr/local/lib/perl5/site_perl/5.12.0/Mail/DKIM/PublicKey.pm line 88,
<GEN28> line 26.

sub fetch_async
{
my $class = shift;
my %prms = @_;

my ($query_type, $query_options) = split(/\//, $prms{Protocol}, 2);
86: if (lc($query_type) ne "dns")
87: {
88: die "unknown query type '$query_type'\n";
}

These warnings come in pairs as a result of verifying a broken signature
with an empty q tag, all coming from youtube.com ("become friends on
YouTube"):

DomainKey-Signature: b=; c=nofws; d=youtube.com; q=; s=selector1

Interestingly, the final result given by Mail::DKIM is:
(invalid, bad identity)

while gmail.com claims:
(bad format)

which sounds more appropriate.

--
submitted by Mark Martinec

[Jason Long]

fixed in 0.39 (not yet released)