dkim_policy() is not keeping state for re-entry when using a policy_lookup callback that returns TRYAGAIN. dkim_policy() will re-request a policy record for which it has already received a result... double elimination.
Discussion
Anonymous
-
2007-11-02
assigned_to: nobody --> sm-msk
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2007-11-02
Logged In: YES
user_id=1048957
Originator: NO
A state variable should fix this. Then the re-execution of dkim_policy() can just skip to where it left off.
Target for 2.4.1.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Attaching a patch that seems to work. I also added a new function dkim_restart_policy() which could be used to restart policy checking from the beginning, basically resetting state to the starting state. Didn't include docs for that, and I don't know what you might want for a proper name for this.
File Added: dkim-policy-state.patch
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2007-12-20
status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2007-12-20
Logged In: YES
user_id=1048957
Originator: NO
A different way of making dkim_policy() re-entrant has been included in 2.4.1, now released.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=1048957
Originator: NO
A state variable should fix this. Then the re-execution of dkim_policy() can just skip to where it left off.
Target for 2.4.1.
dkim-policy-state.patch
Logged In: YES
user_id=627199
Originator: YES
Attaching a patch that seems to work. I also added a new function dkim_restart_policy() which could be used to restart policy checking from the beginning, basically resetting state to the starting state. Didn't include docs for that, and I don't know what you might want for a proper name for this.
File Added: dkim-policy-state.patch
Logged In: YES
user_id=1048957
Originator: NO
A different way of making dkim_policy() re-entrant has been included in 2.4.1, now released.