Re: [Devil-linux-develop] ntop & net-snmp

[Serge L. <fi...@in...>]

Heiko,

I asked my colleague (a very experienced C coder) to help with the patch. After
several hours of the source code looking thru he had said, that the 'really
correct patch' will take a lot of time and efforts which he can't to afford.
Instead of this he suggested a 'quick fix' which allows to compile ntop but
produces the compiler warning. The patch is below, as you can see he just
removed void casting. So, it's the question - will we include this temporary fix
till a proper patch appears or not?

--- include/net-snmp/library/tools.h.orig    2008-02-07 14:43:10.000000000 +0300
+++ include/net-snmp/library/tools.h    2008-02-08 09:57:51.000000000 +0300
@@ -50,7 +50,7 @@

 /** @def SNMP_FREE(s)
     Frees a pointer only if it is !NULL and sets its value to NULL */
-#define SNMP_FREE(s)    do { if (s) { free((void *)s); s=NULL; } } while(0)
+#define SNMP_FREE(s)    do { if (s) { free(s); s=NULL; } } while(0)

 /** @def SNMP_SWIPE_MEM(n, s)
     Frees pointer n only if it is !NULL, sets n to s and sets s to NULL */



Heiko Zuerker wrote:
>> The bug explanation (it is still open):
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=389631
...
> 
> Yeah would be nice if they fix that soon.
> 

--
Sincerely,
Serge Leschinsky