Re: Re[18]: [Devil-linux-develop] Perl build fails?

[Heiko Z. <he...@zu...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey,

I finally had a chance to look over the code and you're right, it is in 2
places. I guess I was blind before.
I'd say do to changes the way you proposed it (the bash version).

On Fri, November 4, 2005 09:01, Serge Leschinsky wrote:
> Dear Heiko,
>
>
> Friday, November 4, 2005, 5:46:19 PM, you wrote:
>
>>>>> +      if [ "$f" = "$s" ]; then
>>>>> +              echo $fi >>  $DL_DIR/tmp/perl-ext.tmp
>>>>> +      else
>>>>> +              if `eval test $s` ; then
>>>>> +                      echo $f >>  $DL_DIR/tmp/perl-ext.tmp
>>>>>
>>>>>
>>>
>>>> Instead of doing the echo here and then parsing the file in the for
>>>>  statement below, it would make sense to cimbine everything and
>>>> compile the module right here.
>>> There are 2 places for the compile code. Code doubling is bad form
>>> and therefore I should write a function... But in this case I have to
>>> save parameters ($1) from parent script. Or haven't? Am I right ?
>>> Could you
>>> please advise me a write way?
>
>> There's actually only 1 place for compiling the perl extensions:
>>
>
> It was the one place . But wrote the code with 2 places (see
> echo $fi). And therefore exactly I use intermediate file.



- --

Regards
  Heiko Zuerker
  http://www.devil-linux.org


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD4DBQFDb9wPUcytMSbs+YURAoJ9AJ4hkXiR8n4ZDDTchph859oXo97IAgCYidGq
RsVdh0VFX3KyXypElWwhiA==
=w+b5
-----END PGP SIGNATURE-----