From: Bruce S. <bw...@ar...> - 2005-04-28 19:45:52
|
> >(See attached file: setup.patch)(See attached file: dhcpd.patch) > > > The patch looks good to me, do we get a "approved by Bruce" stamp ? I've still got a couple issues. (but we're almost there :) First, it's difficult to test the new setup program: patch -p0 < setup.patch patching file setup Hunk #1 succeeded at 550 (offset -1 lines). Hunk #2 succeeded at 562 (offset -1 lines). Hunk #3 FAILED at 621. Hunk #4 FAILED at 646. Hunk #5 FAILED at 680. Hunk #6 FAILED at 881. 4 out of 6 hunks FAILED -- saving rejects to file setup.rej Is the patch for an old version of setup or something? Second, what about the millions of people with an existing dhcpd.conf file, who will just keep that file during the upgrade to 1.2.5? It appears like the dhcpd server on their box will abort until they add the "lease-file-name" line to their dhcpd.conf. We should check if their dhcpd.conf contains a lease-file-name line in the init.d script. If not, start dhcpd the old way (with "-lf") and touch the file, like we did before. - BS |