Re: [Devil-linux-develop] [PATCH] arpwatch_report

[Diego T. <dt...@co...>]

On Fri, Apr 30, 2004 at 09:11:22PM -0500, Frischknecht Peter wrote:

> Attached you will find 2 .diff files.  I created them with go'old "diff -u <old directory> <new directory>".
> arpwatch_report.diff is to be applied directly to the source directory of arpwatch (src/arpwatch-2.1a11).
> arpwatch-report-script.diff is tobe applied against the scripts/arpwatch file.
> I was careful to run "make clean" and I also removed the Makefile files (left Makefile.in).  But since this is my first time...I am bound to screw up.

Several considerations for the next time you send a patch:

don't modify makefiles, better change their value when you call make, i.e:

make ARPDIR=/etc/arpwatch all

better than:

  # Pathname of directory to install database file
  -ARPDIR = $(prefix)/arpwatch
  +ARPDIR = /etc/arpwatch
  +# Pathname of report script
  +REPORT_SCRIPT = /etc/arpwatch/arpwatch_report

it's cleaner and more compatible :)

about the diffs, next time please, send a diff with the "unified"
option: "-u", so humans could understand the diff... ah, and yes, one
more, could you provide an init.d script for arpwatch?
  
-- 
-- gnupg keyfingerprint -- 48AF 5BF9 8F54 2966 64CC  2327 7CD0 DD91 B09D 5799
-- Use of a keyboard or mouse may be linked to serious injuries or disorders.
Diego Torres - dtorres at anthalia dot org - Madrid / España