Re: [Devil-linux-develop] apcuspd not created?

[Roland P. <pa...@ta...>]

On Friday 30 April 2004 09:50, Roland Pabel wrote:
> On Friday 30 April 2004 06:40, Tim Tait wrote:
> > My build from the latest on 4/28 failed to make apcupsd though it was
> > selected. Log shows errors but it did not halt the build.
>
> strange...the build doesn't succeed but neither does it fail...the script
> looks sane to me, every command in the build section is followed by '||
> exit 1'
> I'll test if reverting to 3.10.12 helps or if it's related to the kernel
> update
ok, there are three bugs here:
1) why was the build succesful although it obviously failed - i don't know
2) there is a struct introduced 2.4.26 in include/linux/include/hiddev.h which 
uses an undefined constant HID_MAX_USAGES, because it is actually defined in 
drivers/usb/hid.h
This needs to be fixed for any version of apcupsd. (apcupsd doesn't use the 
struct which uses HID_MAX_USAGES, it's just the compiler complaining).
Google shows this has been reported to LKML, but for some reason it was not 
fixed...Please add linux-2.4.26-hiddev-rp.diff to kernel-patches-2.4.tar.bz2
3) Even when that is fixed, the build fails because Makefile targets can't be 
found in several Makefiles. These vanish when using 'make all' instead of 
'make $PMAKE all', looks like apcupsd doesn't like parallel builds now...but 
I'd recommend keeping 3.10.13, it got tons of bugfixes
Please test my patches, they worked for me(tm)...
Roland
-- 
ICQ UIN 49339118	Linux Counter #88774
GPG-Key 1024D/59C6AFA6 2003-02-07 Roland Pabel <ro...@pa...>