Re: [Devil-linux-develop] Re: [Devil-linux-commit] build/config/etc/init.d network,1.31,1.32

[Bruce S. <bw...@ar...>]

> > I upgraded a firewall of mine and all the static route commands bombed.
> > After a little looking it appeared that the "if" statement below was
> > backwards, so I swapped the logic.  I didn't spend a lot of time looking
> > at the logic of the code, only the results of my routes (which now work)
> > I hope I didn't screw it up too bad, Friedrich!  :-)
> 
> What does your routing entry look like? Would be good to know that as the 
> code that you "fixed" looked ok to me - but I did not dig deeper into the 
> matter.

ifcfg-eth0:
ROUTE="$ROUTE 192.168.2.0/255.255.255.0:172.16.254.1"

ifcfg-eth1:
ROUTE="$ROUTE default/0.0.0.0:10.18.12.19"

(some public IP's changed to protect the innocent :)

> >> 				# add the route
> >>-				if [ -n "${netmask##*.*}" ]; then
> >>+				if [ -z "${netmask##*.*}" ]; then
> >> 					echo "   adding route to $CMD ${target}${netmask:+/$netmask}${gateway:+ via gateway $gateway} on $DEVICE"
> >> 					route add -$CMD ${target} ${netmask:+netmask $netmask} ${gateway:+gw $gateway} dev $DEVICE
> >> 				else
> 
> This line was obviously from a patch from "Cameron Miller".
> http://cvs.sourceforge.net/viewcvs.py/devil-linux/build/config/etc/init.d/network?r1=1.28&r2=1.29
> and
> http://cvs.sourceforge.net/viewcvs.py/devil-linux/build/config/etc/init.d/network

OK.  I just remembered you committing some changes recently.
I didn't remember (or lookup) where they came from.

 - BS