Re: [Devil-linux-develop] [PATCH] linuxrc

[Heiko Z. <he...@zu...>]

Tim Tait wrote:
> Bruce Smith wrote:
> 
>>>>>I made what I think is a few enhancements to the linuxrc script... now 
>>>>>this is my 1st attempt at any real script mods, so I may not have it 
>>>>>all correct.
>>>>>
>>>>>First is simple, I have it check floppies for a config 1st, thus 
>>>>>allowing someone to temporarily test new configs by overiding one 
>>>>>stored on a HD. Probably be good to check other removeable media list 
>>>>>USB 1st too but thats trickier. I don't think this raises a security 
>>>>>risk, cause if someone can put floppies into your machine they can do 
>>>>>a lot worse too.
>>>>>
>>>>>2nd, if you have multiple possible sources of  the configuration file, 
>>>>>if it's not on the first one, it halts the boot to prompt if you want 
>>>>>to write a default one to it. This is really bad, because it hangs the 
>>>>>system on an unattended reboot. So I tweaked the script to check all 
>>>>>media 1st, then if none was found do a 2nd pass to look for blank 
>>>>>media. Of course lastly it still checks the CDROM. Is it possible to 
>>>>>pass the config source from grub as option, like it works for  
>>>>>"root=/dev/hda1"?
>>>>>        
>>>>>
>>>>2nd try with "unified diff" attachment. I couldn't get the cvs diff -run 
>>>>to work, sorry.
>>>>      
>>>>
>>>I can't look into it at the moment, I have a full re-compile running.
>>>Bruce you got time? Otherwise I'll try to do it tomorrow night.
>>>    
>>>
>>
>>I might have time tomorrow.
>>
>>I haven't looked at the patch yet, but I'm not sure about checking for
>>floppy first.  That would check floppy before the USB memory stick.
>>I think the USB flash drive should have priority over the floppy. 
>>Heiko, what's your opinion on that?
>>  
>>
> I think it needs to check both... my thought was if you have a USB 
> config then you are unlikely to leave a floppy in, except to test 
> something. Also, I was not sure how to make it check USB vs a SCSI 
> drive. Either way I think removable media 1st.. of course since I have 
> an IDE CF Card, it get's more convoluted. There probably is no canned 
> config which solves every setup, which is why I was asking about passing 
> it as a parameter from grub for installs to usb/hd .

Sorry, but I don't really "feel" we should change the order.
However, your other changes are still in the queue.

>>Also, the search order for configs need to match the save-config script.
>>It's really confusing if your save goes to a different location than the
>>boot is using.  (believe me, I know that first hand! :)   So, if you
>>change the boot order, you also need to modify the save-config script.
>>
>> - BS
>>  
>>
> I agree on the save-config script, that was my next order of business. 
> Ideally though, save-config should *know* where the source was, not 
> guess. Hot-pluggable media coudl ahve been added since boot, etc. Can't 
> we pass it some how from linuxrc?

We just need to copy'n'paste the specific parts into the save-config script.

Heiko