A question about different states processing in ddru_ntfsfindbad

[olegkrutov]

Hello,

what if to take into account as good only '+' areas in logfile? Currently ddru_ntfsfindbad AFAIK counts as bad only '-' what is wrong as '?','/','' areas are not yet read actually. ddrescuelog --change-types=/?,- helps indeed but it is just workaround.

[maximus57]

Bad(-), non-trimmed(*), and non-split/scraped(/) are supposed to be considered as bad in ddru_ntfsfindbad. If those are not working then there is something wrong. Please double check to see if those are actually not working.

if (type[x] == '-' || type[x] == '/' || type[x] == '*')

I did not include non-tried(?). It would be very easy for me to add that if you feel it is needed. I actually can't remember the reason I left it out.

[KDEboroda]

I propose to change the line
if (type[x] == '-' || type[x] == '/' || type[x] == '*')
with something like this:
if not (type[x] == '+')

[olegkrutov]

Well, it seems that problem is in '?' areas. Anyway, counting it as bad is right and useful when checking domain files and recovering a dirty volume, for example. Currently "?" can show areas where bitmap was not covering a file as recovered what is wrong. If there is some reason to keep current behaviour, then maybe it is worth to make a special cmdline switch?

[maximus57]

The fact that I can't remember why I left it out means it must not have been a very good reason :) Consider it included in the next version.