#28 FreeDNS.afraid.org changed api slightly

[madroach]

The reply to update requests seems to have changed. Here's a patch:

--- ddclient Wed Feb 2 11:03:20 2011
+++ ddclient Wed Feb 2 12:39:21 2011
@@ -3533,7 +3533,7 @@

}
last if !header_ok($h, $reply);

- if($reply =~ /Updated.host/) {
+ if($reply =~ /Updated.$h.to.$ip/) {

success("updating %s: good: IP address set to %s", $h, $ip);

} else {

$config{$h}{'status'} = 'failed';

[madroach]

• attachment _ddclient.patch_ added

patch

[madroach]

• attachment _ddclient.2.patch_ added

[madroach]

Another problem with freedns.afraid.org

The nic_freedns_update subroutine may notice that the ip is already up to date. In this case it still needs to set at least $config{$h}{'ip'}, otherwise the cache file will get corrupt, since it will have an empty ip= property.

ddclient.2.patch (including previous patch for changed api) is attached.

[wimpunk]

• status changed from new to accepted
• milestone set to 3.8

There are to many changes in your indentation to be usable. If you provide a patch with only the changed parts, I'll try to patch it.

[Anonymous]

• attachment _ddclient.diff_ added

[Anonymous]

Don't know what happened to the original submitter... here's a diff with only the changed parts vs svn r122. Let me know if it's ok and you can integrate it.

[wimpunk]

• status changed from accepted to closed
• resolution set to fixed

Patch applied as r126.