|
From: Richard H. <no...@gi...> - 2020-06-27 01:02:04
|
Branch: refs/heads/master Home: https://github.com/ddclient/ddclient Commit: 4edecf3dc1ee680d31396a638e8ae66079cc2dfd https://github.com/ddclient/ddclient/commit/4edecf3dc1ee680d31396a638e8ae66079cc2dfd Author: Richard Hansen <rh...@rh...> Date: 2020-06-25 (Thu, 25 Jun 2020) Changed paths: M ChangeLog.md M ddclient Log Message: ----------- Turn `fw-banlocal` into a no-op and mark it as deprecated `fw-banlocal` is problematic: * There's not much point to it. Regardless of whether it is enabled, the end result is a DNS record that is not being updated to a useful value. It does cause a warning to be logged, but because it is not enabled by default it doesn't help the poor user who is trying to figure out why they can't reach their machine. By the time they realize that enabling this option would have saved them hours of troubleshooting, they no longer need to enable it because they already know what the problem is. * It's a misnomer: `fw-banlocal` doesn't just filter out local IP addresses from `use=fw`, it also filters them out of all other address sources except `use=ip`. * It doesn't filter out local IPv6 addresses. * The resulting warning ("unable to determine IP address") is misleading. We might want to add a warning whenever a non-global address is discovered (along with an option to silence the warning), but that should be done in a future commit if at all. Commit: 7556aaa5e1b0ac67122edf9a73da62d1f07251e0 https://github.com/ddclient/ddclient/commit/7556aaa5e1b0ac67122edf9a73da62d1f07251e0 Author: Richard Hansen <rh...@rh...> Date: 2020-06-26 (Fri, 26 Jun 2020) Changed paths: M ChangeLog.md M ddclient Log Message: ----------- Merge pull request #191 from rhansen/deprecate-banlocal Turn `fw-banlocal` into a no-op and mark it as deprecated Compare: https://github.com/ddclient/ddclient/compare/08c7e7135271...7556aaa5e1b0 |
