Patches item #2842732, was opened at 2009-08-22 22:39
Message generated for change (Tracker Item Submitted) made by skangas
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=676130&aid=2842732&group_id=116817
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stefan Kangas (skangas)
Assigned to: Nobody/Anonymous (nobody)
Summary: ddclient.cache doesn't get IP if server doesn't echo it
Initial Comment:
Attached is a patch which fixes a bug which will appear in some cases where service providers give status responses not containing the client's IP address. Currently, ddclient relies on this behaviour and if the service provider gives a broken response it will lead to errors as detailed in the bug report in the Debian BTS (linked below).
Here's a log from where I've reproduced this error with my own service provider:
$ ./ddclient -debug -file ddclient.conf -cache ./ddclient.cache
DEBUG: proxy =
DEBUG: url = http://www.whatismyip.com/automation/n09230945.asp
DEBUG: server = www.whatismyip.com
DEBUG: get_ip: using web, http://www.whatismyip.com/automation/n09230945.asp reports 81.xx.xx.xx
DEBUG:
DEBUG: nic_dyndns2_update -------------------
DEBUG: proxy =
DEBUG: url = http://xxxxx/nic/update?system=custom&hostname=xxxxx&myip=81.xx.xx.xx&wildcard=ON
DEBUG: server = xxxxxx
Use of uninitialized value $_[2] in sprintf at ./ddclient line 1550.
SUCCESS: updating xxxxx: good: IP address set to
$ cat ddclient.cache
## ddclient-3.8.0
## last updated at Sat Aug 22 22:22:20 2009 (1250972540)
atime=1250972540,backupmx=0,custom=1,host=xxxxxxx,ip=,mtime=1250972540,mx=,static=0,status=good,warned-min-error-interval=0,warned-min-interval=0,wildcard=1,wtime=0 xxxxxx
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528950
This patch is tested and verified working by myself. Please consider including this patch in ddclient.
Regards,
Stefan Kangas
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=676130&aid=2842732&group_id=116817
|