Menu

#101 FreeDNS Get Update URLs Broken

current_version
open
nobody
None
5
2019-06-28
2019-06-28
David Lutz
No

When the FreeDNS look up attempts to fetch the URLs available to update, it ends up using a malformed SHA1 Hash, seemingly due to incorrect concatenation.

Replace this line:

$url = "http://$config{$_[0]}{'server'}/api/?action=getdyndns&sha=".&sha1_hex("$config{$_[0]}{'login'}|$config{$_[0]}{'password'}");

With this line:

$url = "http://$config{$_[0]}{'server'}/api/?action=getdyndns&sha=".&sha1_hex("$config{$_[0]}{'login'}"."|"."$config{$_[0]}{'password'}");

And the connection functions as expected.

Note that I'm not familiar with this language what so ever so there may be a much better/cleaner way to perform this concatenation... This is just what I could get working.

Discussion


Log in to post a comment.