From: Steven S. <ste...@gm...> - 2007-12-14 20:10:38
|
Jacek Sieka wrote: > Steven Sheehy wrote: >> Use the standardized C99 types. This is our fault for not checking it >> when we added the *nix fast hash. :D > ok. ever considered mmap? fasthash() already does use mmap... >> Fixes the disconnected string showing in the transfers pane before the >> no slots available status. > I discussed this patch with razzloss and we both came to the conclusion that its the responsability > of the gui to tell which error messages to display from where...besides, I'm anticipating some > changes to the transfer view now that we have segmented downloading in the core... Great, razzloss failed to mention this... >> Description from original patch writer: >> >> My computer is connected to 2 huge LANs and the internet. >> Respectively, the outside world knows it by 3 different IPs. > > While the patch itself seems fine, I'll be needing agreement from the original patch author before I > add this...I'd also like to know who it was that wrote it in order to give due recognition (if the > author wants)... The author is Stanislav Maslovski. I cc'd him so he can provide his input. -Steven |