Re: [dcplusplus-devel] patch: updates VC headers to match changes in GCC headers

[Jacek S. <arn...@gm...>]

> I still have no idea what you're on about, so I'd really like a better
> explanation. The defines are commented out, what's the problem?
windows.h does #define min(a,b), c++ does it using a template. We don't want to use the windows
version because it's not typesafe. dc++ uses min/max all over the place (for examples Streams.h:86)
so if you don't have #undef min, the windows.h version will preferred over the c++ version since the
preprocessor is run first and typesafety goes away. The best solution I've found so far is to
undefine min/max since I don't want to put parentheses around each min...makes sense?

> As far as compiling goes, openssl is the best open-source project I
> have ever seen (i.e. it actually compiled first time). It just needed
> some tweaks to its default CRT linking options to match those used by
> DC++, or all hell breaks loose when linking with DC++. Smile emoticon
That's because it's one of the few opensource libs that are actively being used with msvc...boost
would be another example, python extensions another (the mess with python is when you want to use
mingw instead because of how they depend on msvcrt)

what I don't like is the advertising clause in their license, it forces you to put a certain string
in a visible place in your app. I tend to put the ads anyway out of courtesy, but I believe it
should be voluntary.

/J