Re: [dcplusplus-devel] ValidateFileName problem on Macintosh...

[poy <po...@12...>]

yeah right - ignore that patch. :/

i guess validateFileName() tries to keep the path, cleaning only nested =
paths and bad chars. it might need to get re-written: no need to look =
for "/./", "//", etc when all '/' have been cleared.

itinerants, are you sure it "doesn't work" on Mac?

poy
  ----- Original Message -----=20
  From: James Ross=20
  To: DC++ Devel=20
  Sent: Thursday, November 15, 2007 2:27 PM
  Subject: Re: [dcplusplus-devel] ValidateFileName problem on =
Macintosh...


    From: poy=20
    Sent: Thursday, November 15, 2007 1:13 PM
    To: Patches & development discussion=20
    Subject: Re: [dcplusplus-devel] ValidateFileName problem on =
Macintosh...


    little fix, not tested of course.

    as for ':', have a look at line 198 of Util.cpp. ;)
  Won't the addition of "/" to the list already containing "\" mean that =
all the bits of ValidateFileName which appear to be doing some path work =
will never match? One of the comments even implies it will be given =
absolute paths, which are never going to work if you replace "/" and "\" =
with "_", no?

  I guess the important question is whether ValidateFileName is expected =
to accept and return a simple filename with no paths anywhere or not =
and, if if paths are allowed/expected, are they meant to be preserved in =
the output?

  --=20
  James Ross


-------------------------------------------------------------------------=
-----


  =
-------------------------------------------------------------------------=

  This SF.net email is sponsored by: Splunk Inc.
  Still grepping through log files to find problems?  Stop.
  Now Search log events and configuration files using AJAX and a =
browser.
  Download your FREE copy of Splunk now >> http://get.splunk.com/


-------------------------------------------------------------------------=
-----


  _______________________________________________
  dcplusplus-devel mailing list
  dcp...@li...
  https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel