From: James R. <si...@wa...> - 2007-11-15 13:27:20
|
From: poy=20 Sent: Thursday, November 15, 2007 1:13 PM To: Patches & development discussion=20 Subject: Re: [dcplusplus-devel] ValidateFileName problem on = Macintosh... little fix, not tested of course. as for ':', have a look at line 198 of Util.cpp. ;) Won't the addition of "/" to the list already containing "\" mean that = all the bits of ValidateFileName which appear to be doing some path work = will never match? One of the comments even implies it will be given = absolute paths, which are never going to work if you replace "/" and "\" = with "_", no? I guess the important question is whether ValidateFileName is expected = to accept and return a simple filename with no paths anywhere or not = and, if if paths are allowed/expected, are they meant to be preserved in = the output? --=20 James Ross |