From: James R. <si...@wa...> - 2007-11-11 18:57:25
|
-------------------------------------------------- From: "Jacek Sieka" <arn...@gm...> Sent: Sunday, November 11, 2007 4:23 PM To: "Patches & development discussion" <dcp...@li...> Subject: Re: [dcplusplus-devel] patch: updates VC headers to match changes in GCC headers > What's the deal with the min/max comment? afair windows.h defines ugly > versions of min/max? It was all commented out, and all the places which use std::min or std::max are wrapped in parentheses as the comment notes (except one). I don't think it needs to have the commented-out defines, but the comment could be left instead? > James Ross wrote: >> Note that there are other patches I've got to completely make building >> with MSVC work. > Well, the msvc maintainer post is open =) As long as they're not > workarounds for deficiencies in the > compiler, they're most welcome in the main repository... Thanks, most of it was making it link with openssl (and compiling openssl with the right flags). :) -- James Ross |