Re: [dcplusplus-devel] Fw: patch: let windows draw ListView arrows

[poy <po...@12...>]

> The simplest, but less than ideal, fix I've found is to move the common
> control check in the Seed constructor into WidgetListView::create. Better
> ideas welcome - especially ones which don't do the check on every list 
> view
> creation!

thought about that, and doing the check on every listview creation was 
definitely a problem to avoid; that's why the function is static in the 
first place.
i just added a debug line in getCommonControlsVersion and i can confirm it's 
only called on the program start, not afterwards when other list views are 
created.

> Note that the most likely reason this has affected me and not others is 
> that
> I'm probably the only one building with MSVC. I am only to assume GCC is
> being lucky here, as I can't find any indication that it's actually a bug 
> in
> either compiler, it's just undefined behaviour, which is a right pain.

if it is undefined behaviour and GCC is only being lucky, it has to be 
fixed, though i don't really know how. however i can imagine that GCC isn't 
only being lucky, but also being smart in that it understands that the 
critical section has to be initialized first...

poy