Re: [dcplusplus-devel] Source level bug (probably) report

[Fredrik U. <ul...@gm...>]

On Nov 3, 2007 9:22 PM, itinerants <iti...@ho...> wrote:
> 4. The AutoSearch thing...
> It saves a list of the 30 last "searched for" strings.
> This means that, if you have, say, 29 items in your list, once they've all
> been searched for, no more autosearching is performed, yet if you have 31,
> it'll keep cycling around.
> I fixed this by clearing the list if nothing to search for is found, then,
> next time around, we're back searching again.
>
> 5. The autosearch interval needs to be user-specifiable. It's either 120000,
> or 300000, but some hubs have 10 minute minimum search intervals! On those
> hubs, autosearch never finds anything after the first one, since the hub
> bounces every subsequent search as being within the minimm search interval.
>

If there's less than 30 items, DC++ should start over again with the
queue. (It didn't at some point, and a patch was provided to fix it.
This was quite a long time ago.) However, there's still bugs in that
code; The code only checks for the total size of the queue, and not
the size of the files that are eligable for autosearch. That is, if
there's a file that's set to paused or is running etc, and there's
less than 30 items, the autosearch mechanism will (then) break.

I'm not sure if a user defined search interval would be useful. First
off, most people would probably keep the interval at its minimum. The
setting seem to be only useful in those instances where the hub has a
completely silly minimum interval, and it feels bad to endorse that
kind of behaviour where massive user count is the goal (and the hub's
reasoning of setting a silly minimum interval to preserve bandwidth).

-- 
Fredrik Ullner