|
From: poy <po...@12...> - 2010-01-10 18:12:28
|
hi,
here is a patch to implement a blacklist function in order to alert the user
when a hub list has fallen into the wrong hands. when such a hub list is
selected by the user, the following message appears on top of the tab:
---
Warning: fraudulent hub list detected!
The current hub list ([url of the list]) has been blacklisted by DC++ for
the following reason:
[reason]
It is strongly recommended that you do not connect to any of the hubs listed
here and that you remove this hub list from your collection by using the
"Configure" button below.
---
(see attached screen-shot)
the list can be updated via version.xml with this format:
<Blacklist>
<Blacklisted Url="..." Reason="..."/>
<Blacklisted Url="..." Reason="..."/>
</Blacklist>
(i haven't tested that particular update function.)
there has been concerns about the danger of allowing outside parties to
remove hub lists in all DC++ out there; instead, this solution only displays
an explicative message to the user, but doesn't act on her behalf. i hope
this is an acceptable compromise.
as for performance, there shouldn't be much difference because the text-box
control used to host the blacklist message is only created when needed, and
destroyed afterwards.
the default blacklist contains only 1 list at the moment:
<http://adchublist.com/hublist.xml.bz2>
with the reason: "Domain used for spam purposes."
note that there is room for way longer explicative reasons if needed.
poy
|