[dcplusplus-devel] use of the User::PASSIVE flag

[poy <po...@12...>]

searching for "User::PASSIVE" in the dcpp files shows that the flag is only 
set and un-set for users in NMDC hubs; however, it is being checked for in a 
couple of protocol-agnostic places:

in ConnectionManager::on(TimerManagerListener::Second:
    if(cqi->getUser().user->isSet(User::PASSIVE) && 
!ClientManager::getInstance()->isActive()) {
     passiveUsers.push_back(cqi->getUser());
     removed.push_back(cqi);

in QueueManager::addSource:
 if(aUser.user->isSet(User::PASSIVE) && 
!ClientManager::getInstance()->isActive() ) {
  qi->removeSource(aUser, QueueItem::Source::FLAG_PASSIVE);

as a result, it is likely that this feature that removes passive users from 
the queue is not working for ADC hubs. ideally Identity::isTcpActive would 
be used instead but i'm not sure how it can be applied there.

poy