Re: [dcplusplus-devel] patch: tracking of opened windows

[Jacek S. <arn...@gm...>]

Steven Sheehy wrote:
> I don't understand the need to put user interface logic inside of the core.
> WindowManager would be better suited inside of the win32 folder. The DC++ core
> is supposed to be a "library" and thus should not have any knowledge of any user
>  interface this is invoking its APIs or responding to its events. In my opinion,
> the SettingsManager as it is now needs to be redone so that settings that are
> used only in the GUI are moved outside of the core (like we did with win32-only
> translatable strings). This could be done by making a WindowsSettingsManager
> that extends the core SettingsManager and adds extra Windows specific settings.
> If this was done, it would be much more natural to place WindowManager in win32/.

Generally, I'd agree that some of the dcpp/ stuff doesn't belong there, but it's been left as a
matter of convenience. There also some things that make sense for most potential ui's that
technically don't belong in dcpp but that all ui's can benefit from, so they are still there ("show
nick of joining user in chat")...a ui support library would maybe make sense but we also have to
consider increased maintenance and the actual work to move stuff etc...

/J