Re: [dcplusplus-devel] patch: tracking of opened windows

[poy <po...@12...>]

----- Original Message ----- 
From: "Steven Sheehy" <ste...@gm...>
To: "Patches & development discussion" 
<dcp...@li...>
Sent: Friday, February 20, 2009 4:36 AM
Subject: Re: [dcplusplus-devel] patch: tracking of opened windows


>I don't understand the need to put user interface logic inside of the core.
> WindowManager would be better suited inside of the win32 folder. The DC++ 
> core
> is supposed to be a "library" and thus should not have any knowledge of 
> any user
> interface this is invoking its APIs or responding to its events. In my 
> opinion,
> the SettingsManager as it is now needs to be redone so that settings that 
> are
> used only in the GUI are moved outside of the core (like we did with 
> win32-only
> translatable strings). This could be done by making a 
> WindowsSettingsManager
> that extends the core SettingsManager and adds extra Windows specific 
> settings.
> If this was done, it would be much more natural to place WindowManager in 
> win32/.
>
> -Steven


all current auto-open and auto-connect options are in dcpp/ (in 
SettingsManager and FavoriteManager respectively) so for simplicity and to 
avoid restructuring everything i left WindowManager in dcpp/ too.
i originally thought of making the GUI thread listen to settings load/save 
events but it appeared that these can occur when the GUI has already been 
closed, thus making it impractical to find child windows that were opened 
before closure. having WindowManager in dcpp/ just like every other similar 
*manager/*listener is just the most natural with the current architecture.

it would surely be nice to move out auto-open options as well as column 
sizes and other GUI options but that is not the purpose of this patch.

poy