From: Steven S. <ste...@gm...> - 2009-02-20 03:37:38
|
I don't understand the need to put user interface logic inside of the core. WindowManager would be better suited inside of the win32 folder. The DC++ core is supposed to be a "library" and thus should not have any knowledge of any user interface this is invoking its APIs or responding to its events. In my opinion, the SettingsManager as it is now needs to be redone so that settings that are used only in the GUI are moved outside of the core (like we did with win32-only translatable strings). This could be done by making a WindowsSettingsManager that extends the core SettingsManager and adds extra Windows specific settings. If this was done, it would be much more natural to place WindowManager in win32/. -Steven poy wrote: > reworked a bit in order to auto-open PMs. added virtual StringMap > getWindowParams() in MDIChildFrame that child windows can override to > return their own params (hubs return their address, PMs their CID & base > hub). > > poy |