From: poy <po...@12...> - 2008-07-08 13:12:38
|
i linked to that thread so that patch can go there; also, i guess Jacek's comments in there apply to your patch too since it's basically the same as the 2nd one i posted, except yours applies only to TypedTable's whereas mine was about making it for all Table's. poy ----- Original Message ----- From: "Pär Björklund" <per...@gm...> To: "poy" <po...@12...>; "Patches & development discussion" <dcp...@li...> Sent: Monday, July 07, 2008 4:35 PM Subject: Re: [dcplusplus-devel] Patch: Fixed ctrl+a handler for TypedTable >I don't know much about Smartwin/DWT but your patch linked to in that > thread seems overly complex for such a smal feature Poy. > > And looking at the tryFire code it seems to not follow the Windows way > of short circuiting the message loop once a message is deemed handled. > This could probably lead to some interesting behavior where two > different handlers think they handled the message. Could probably lead > to handler ordering bugs and other things that are unpleasant to track > down. > > I did not try my patch that much but it seems to give the expected > behavior, please give an example where it would fail. > > On Mon, Jul 7, 2008 at 2:49 PM, poy <po...@12...> wrote: >> https://bugs.launchpad.net/dcplusplus/+bug/203763 >> >> poy >> >> ----- Original Message ----- >> From: Pär Björklund >> To: dcp...@li... >> Sent: Saturday, July 05, 2008 1:35 PM >> Subject: [dcplusplus-devel] Patch: Fixed ctrl+a handler for TypedTable >> >> >> A small patch to fix the ctrl+a handler for TypedTable >> >> >> >> >> >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> >> >> >> _______________________________________________ >> dcplusplus-devel mailing list >> dcp...@li... >> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel >> >> >> ------------------------------------------------------------------------- >> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! >> Studies have shown that voting for your favorite open source project, >> along with a healthy diet, reduces your potential for chronic lameness >> and boredom. Vote Now at http://www.sourceforge.net/community/cca08 >> _______________________________________________ >> dcplusplus-devel mailing list >> dcp...@li... >> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel >> > > |