From: Jacek S. <arn...@gm...> - 2008-06-22 09:33:23
|
Michael Jones wrote: > Just got a few queries / suggestions . . . . > > In October i sent in a patch to this mailing list to remove a lot of white space from the source code, but since it was so big, it needed to be "authorized" or something. Since a lot has changed in the source since then, the old one i did is useless and will need to be redone (and never turned up here). So to prevent this issue in the future can i commit whitespace removal directly, or should i open a launchpad bug report, which could always stay open and just receive patches for removing white space ? Commit janitorial tasks directly > On a side note with this, i remember that in the copy write notice on the top of all the DC++ files there was a full stop followed by two spaces, it would make white space finding and removal a lot easier if this was changed to one space following the full stop. So in a future whitespace patch, would it be acceptable to remove this extra space from the copy write notices ? Feel free to remove any redundant whitespace (and convert spaces to tabs where needed, assuming 4 spaces per tab. > Regarding cross compiling, when i was using 32bit ubuntu, and now on 64bit debian this had to be added to the command line scons call > prefix=i586-mingw32msvc- > whereas on compiling with windows it isn't needed. > So could a SConscript change be made so that if OS == Windows, leave as is, and if OS == Linux automatically use that prefix. Just to make it nicer / easier. > Or is there a case where i386 mingw maybe used on Linux ? It depends on the linux distribution...debian uses i386 for example...you can put that (or any) option in a file called custom.py: ------ cut prefix = "blabla" ------ cut > Regarding translations, FleetCommand mentioned earlier that BCDC uses PM in the time sense, and this could conflict with the User Commands page occurrence of PM (for Private Message), and i thought in this case, the User Commands one could just be changed to Private Message. > This also got me thinking, since BCDC uses launchpad now for the bzr repository, they have to sync translations with DC++'s updates. Whereas DC++ has the nice launchpad translation page, BCDC is deprived of this. To make this nicer for branches / mod's of DC++ i thought that a "dummy.cpp" file could be added to both dcpp and win32 directories, which is skipped from compiling, but scanned by gettext. This would mean that if mod authors could put text's in there, to be translated, and would turn up on the launchpad's translation page. And it wouldn't / shouldn't affect DC++ adversely. Mods should keep their own translation pages - I don't want to burden translators with extra work that they might not want to do. |