Re: [dcplusplus-devel] patch: Filter already shared files in search

[Smir <dcp...@sm...>]

Hi,

ok, I fixed the patch. It was the first time for me working with bazar, but now
the patch looks fine :)
I also fixed those other two issues.

Bye,
Smir

> Hi,
> 
> Thanks for the patch, but there are a few errors. First off, it seems that
> the bzr patch you sent is 
> empty - I think you need to commit your changes locally (which is the default
> if you used "bzr 
> branch") before doing "bzr send" - it gives the diff between the branch
> source and your commit, not 
> what you have in your working tree. bzr diff will produce a diff against the
> working tree, but it 
> won't include information about which revision you started from so a "bzr
> send" is preferable - I'm 
> not very good with bzr though so I'm not sure - any form will be fine.
> 
> Second, you didn't add the setting to the strings in settingsmanager.cpp so
> it won't actually be 
> loaded/saved.
> 
> Third you can use a reference here: "TTHValue t = aResult->getTTH();" 
> becomse "const TTHValue& t = 
> aResult->getTTH();"...
> 
> Regards,
> /J