Re: [dcplusplus-devel] patch: icons (and more) in the main menu

[poy <po...@12...>]

> Let's hope this is wine compatible =)
you tell me... ^^

> On a more serious note; I wonder what this does to the blind - from what I 
> gather there are actually
> blind people using dc++ and they were more than happy with the new menus 
> since they're better for
> their screen readers...let's hope this patch doesn't interfere...
this still uses standard Windows menus, and adds the text just as in usual 
menus:
info.dwTypeData = const_cast< LPTSTR >( text.c_str() );
on line 802 of WidgetMenuExtended.cpp; only difference is that the menus are 
custom drawn. hopefully that won't be a problem for these programs...

> Also, at some point, for consistency, all right-click menus should 
> probably be moved to this fancy
> stuff as well (commit directly if you feel like doing this...)
i've thought about this, yep. :)

> Would the transparency settings for bitmaps be better off in the seed?
yes, the MenuColorInfo info can now be set through the Seed. also, popup 
menus appended to a WidgetMenuExtended will now use the same default color 
settings as their parent.

> Does it take its default menu colors from the system that it'll blend in?
good question. fortunately, yes, it does (in the MenuItemData and 
MenuColorInfo constructors). :)

> To fix:
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h: 
> In constructor
> 'SmartWin::WidgetMenuExtended::WidgetMenuExtended(SmartWin::Widget*)':
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:501: 
> warning:
> 'SmartWin::WidgetMenuExtended::drawSidebar' will be initialized after
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:498: 
> warning:
> 'SmartWin::FontPtr SmartWin::WidgetMenuExtended::itsTitleFont'
> smartwin/source/widgets/WidgetMenuExtended.cpp:872: warning:   when 
> initialized here
fixed. i don't understand why the warning, though; could initializing a 
class member before another be a problem, just because they were declared in 
the reversed order?

poy