Menu
▾
▴
Re: [dcplusplus-devel] Patch
|
From: Eugen <pi...@de...> - 2008-02-06 17:32:46
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=windows-1252"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks for explanations. I figured out what was the problem.<br>
<br>
Todd Pederzani wrote:
<blockquote
cite="mid:9ca...@ma..."
type="cite">On Feb 6, 2008 11:52 AM, Eugen <<a
moz-do-not-send="true" href="mailto:pi...@de...">pi...@de...</a>>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">Probably because i modified
the about years on the beggining and the
diff had to include all lines between that and the other modification ?</div>
</blockquote>
<div><br>
It included them in the patch because they had changed, otherwise it
would just have collapsed them, just as it did in MainWindow.cpp<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">Why everybody is telling me
about a text editor? what does this have to
do with patch ? I made tortoise svn create patch which made the file i
attached. No file editor was used.</div>
</blockquote>
<div><br>
The patch deletes all of AboutDlg.cpp and replaces it with new text. I
can't tell which changes you made, which makes it hard for me to review
the patch (although there's no particular reason why I need to). In
comparison, see the attached diff, which I created by the command line
diff tool. I set it to create a minimal patch and ignore whitespace.<br>
<br>
And it's far from "everybody", it's just me, and Matt Pearson decided
to chime in as well.<br>
<br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">Why should line endings
increase the size ? If there are 100 lines
thats 100 bytes to 100x100 bytes that is less than 1 % size.</div>
</blockquote>
<div><br>
If you change the line endings, or convert spaces to tabs (or vice
versa), or remove whitespace, that counts as a change, and the diff
includes it (and the whole line on which the change took place). Based
on the patch, the original file had only 0x0a as line endings, and your
editor converted it to 0x0d 0x0a. <br>
</div>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">If a 10 kb patch instead of a
2kb one is a problem then hell, what else
do i have to say<br>
Has any of you either bothered to open the attached file and see whats
there?<br>
If you dont like the patch say so ... i wont bother again.</div>
</blockquote>
<div><br>
</div>
</div>
Whoah, don't overreact. Look at your patch and see if you can keep
track of what is is doing to AboutDlg.cpp, and then look at the one
I've included. Mine is much easier to read and understand. When I was
regularly submitting patches, I always kept a clean version, and a
working version, and I used a batch file to create a minimal unified
diff that ignored whitespace. It was a little awkward at first, but I
got into a rhythm with it.<br>
<br clear="all">
<br>
-- <br>
Todd Pederzani<br>
<a moz-do-not-send="true" href="mailto:tod...@gm...">tod...@gm...</a>
<pre wrap="">
<hr size="4" width="90%">
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
<a class="moz-txt-link-freetext" href="http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/">http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/</a></pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
dcplusplus-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dcp...@li...">dcp...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel">https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel</a>
</pre>
</blockquote>
<br>
<br>
</body>
</html>
|
