Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

Michael Jones wrote:
> Just a few more queries to finish off most off win32 (excluding the stuff which may need Keyboard Accelerators) 
> 
> The F_ macro doesn't work in win32.  Somethings in HubFrame.cpp and WinUtil.cpp could do with it. e.g. 
> 	speak(ADD_STATUS_LINE, STRING(CONNECTING_TO) + client->getHubUrl() + "...");
> 	LogManager::getInstance()->message(STRING(MAGNET_DLG_TITLE) + ": " + Text::fromT(aUrl));
> Should something like this be added to stdafx.h ?
> 
> #define F_(String) boost::format(gettext(String))
This one...

> and if so, inside or outside the ifdef unicode thingy ?
Outside...unicode is for tstrings while strings and wstrings go outside...

> I really have no idea of what to do to the two functions which do this
> 	if (ResourceManager::getInstance()->isRTL())
Neither do I =) That's supposed to say which languages are right-to-left, but I'll have to find some
smart way of doing that now that it's not part of the xml file...leave the call for now.

> The Toolbar stuff in MainWindow.cpp, e.g.
> 	toolbar->appendItem(IDC_RECONNECT, image++, TSTRING(MENU_RECONNECT));
> 
> i assume this is for the Tooltips.  But the tooltips don't display accelerators or shortcut keys, so should it keep them ? 
Hm, make it without...I think &'s are stripped automagically but it makes little sense to keep them
there and it'll look more natural...

> (not all of them use the right stringdef for the accelerators & shortcuts keys to be displayed, so if keeping, should these be changed to the ones which have them ?)
In general, it would be good to have unique accels in all the right-click menus and most of the main
menu, so if they're missing, you're welcome to add them...

> Also is the AWAY string in caps for a reason ?  
> The two places which use it are MainWindow.cpp:294
> 	statusSizes[STATUS_AWAY] = status->getTextSize(TSTRING(AWAY)).x + 12;
> 
> and MainWindow.cpp:550
> 	setStatus(STATUS_AWAY, Util::getAway() ? TSTRING(AWAY) : _T(""));
Yeah, usually this kind of on/off indicators in the status bar are allcaps from what I've seen (most
often they refer to INS/OVERWRITE indicators in text editors...)...but if you have evidence that
points in another direction...

/J