Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

> And for STRINGS(BLAH) should the T_ macro be used, or a different one ?
STRINGS?

> Also what macro should be used in the dcpp area ?
same as win32

> SearchFrame.cpp:1056
> For the search window's title bar which is better ?
> 	setText(T_("Search") + _T(" - ") + T_("Ready to search..."));
> 	setText(T_("Search - Ready to search..."));
Second option

> Also wasn't sure if the Registry Entries (e.g. for Magnet stuff) in WinUtil.cpp should be translatable or not ?  Or just some of them. 
> ( Especially regarding MAGNET_HANDLER_ROOT which is "DC++" )
Those that are STRING's should be translated and the others no?

> This was used in PublicHubFrame, before the cache was introduced.  Since nothing uses it now, can it be removed, or it want to stay ? 
> 
> #ifdef PORT_ME
> double WinUtil::toBytes(TCHAR* aSize) {
> blah
Let it be...

> 
> Also do the "new"s in SettingsFrame need a corresponding "delete"? Because i couldn't see the pages getting deleted anywhere.
Hm, I think smartwin deletes those, but now that you say it, I'm not so sure...I'll check later on...

> There is also a "new" in Util formatTime for non win32 stuff, but i couldn't see any delete for that either.
AutoArray takes care of that...

> And last thing, there seems to be a issue with SpyFrame. Open Spyframe and just put dc++ in the background for a few minutes and it crashes most the time.  If it doesn't after about 5 mins, clicking the Settings button makes it crash.  Never get an exceptioninfo or a call stack when ran in debug build though.  But at least it is reproducible. :)
Yeah, I've heard about that...tell poy =)

/J