Re: [dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

> I removed some parts of the patch were there were still strings in the fo=
rm TSTRING(BLAH) + xxx
> which should become TF_("Blah %1%") % xxx so that the parameter can be mo=
ved...
Sorted them now.

> By my count, there are now approximately 290 strings left (more or less 1=
45 in each of win32 and
> dcpp =3D) and about the same number already done which means that we're a=
t 50% !
nice, going well then. :)

>> How should CTSTRING(BLAH) end up ?
>CT_ (which is a new macro: "#define CT_(String) T_(String).c_str()")
i didn't realise that this was so new it needed putting in stdafx.h =3D)
And for STRINGS(BLAH) should the T_ macro be used, or a different one ?

Also what macro should be used in the dcpp area ?

Have a few queries for the ones I working on now (still win32):


SearchFrame.cpp:1056
For the search window's title bar which is better ?
	setText(T_("Search") + _T(" - ") + T_("Ready to search..."));
	setText(T_("Search - Ready to search..."));


Also wasn't sure if the Registry Entries (e.g. for Magnet stuff) in WinUtil=
.cpp should be translatable or not ?  Or just some of them.=20
( Especially regarding MAGNET_HANDLER_ROOT which is "DC++" )


This was used in PublicHubFrame, before the cache was introduced.  Since no=
thing uses it now, can it be removed, or it want to stay ?=20

#ifdef PORT_ME
double WinUtil::toBytes(TCHAR* aSize) {
blah


Also do the "new"s in SettingsFrame need a corresponding "delete"? Because =
i couldn't see the pages getting deleted anywhere.
There is also a "new" in Util formatTime for non win32 stuff, but i couldn'=
t see any delete for that either.


And last thing, there seems to be a issue with SpyFrame. Open Spyframe and =
just put dc++ in the background for a few minutes and it crashes most the t=
ime.  If it doesn't after about 5 mins, clicking the Settings button makes =
it crash.  Never get an exceptioninfo or a call stack when ran in debug bui=
ld though.  But at least it is reproducible. :)

thanks=20
MikeJJ
_________________________________________________________________
Free games, great prizes - get gaming at Gamesbox.=20
http://www.searchgamesbox.com=