From: Jacek S. <arn...@gm...> - 2008-01-17 22:36:17
|
> Right, this patch is like the last one, but gets rid of all calls to tformat, and as of which i have removed it from Text.h. I also changed my nick in a couple of places on this one. Good. > QueueFrame.cpp > The reason i have left the if == 1 in here, and used TF_ for the plural part is because off the numbers of arguments after it. Which causes some Boost exceptions to be thrown. E.g. in the top one, 0 of the arguments are used, but the>1 part uses 2 arguments. Looks good to me... > > TransferView.cpp > Heh, these were a nightmare to get working. :( As long as they work =) > I also deleted this, because nothing was using it: > void TransferView::on(UploadManagerListener::Tick, const UploadList& ul) throw() { > - AutoArray buf(TSTRING(UPLOADED_BYTES).size() + 64); good. I removed some parts of the patch were there were still strings in the form TSTRING(BLAH) + xxx which should become TF_("Blah %1%") % xxx so that the parameter can be moved... By my count, there are now approximately 290 strings left (more or less 145 in each of win32 and dcpp =) and about the same number already done which means that we're at 50% ! /J |