Menu
▾
▴
Re: [dcplusplus-devel] Some more translations again
|
From: Jacek S. <arn...@gm...> - 2008-01-15 22:38:01
|
Michael Jones wrote:
> Some more translations. :)
>
> Just a few comments with this one.
>
> In Search frame, for the "Type" drop down, i left the _T("TTH") as i didn't think this needs translation, but all the others in that drop down use the T_ type.
> Did this want changing to T_, or is it fine as is ?
Change to T_, in case someone wants to put something more descriptive...
> In WinUtil.cpp also added this line:
> Util::setManualAway(false);
>
> a little over site from when i fixed:
>
> * Manual away setting no longer cleared when un-minimizing (thanks pothead)
>
> (it got used in the /away command when already away, but i missed adding it to the /back command :S )
Ok
> Also in QueueFrame.cpp i left this part:
> } else if(getSources().size() == 3) {
> display->columns[COLUMN_STATUS] = TSTRING(ALL_3_USERS_OFFLINE);
> } else if(getSources().size() == 4) {
> display->columns[COLUMN_STATUS] = TSTRING(ALL_4_USERS_OFFLINE);
> } else {
> _sntprintf(buf, 64, CTSTRING(ALL_USERS_OFFLINE), getSources().size());
> display->columns[COLUMN_STATUS] = buf;
> }
>
> because i thought that the "else if" for sizes 3 and 4 could be removed, as it will get the same output for that amount of sources, on the "fall through" thingy.
> Also wasn't sure if the whole _sntprintf / buffer part was needed for the last bit, or if a T_("All %d users offline") could be used instead, like in T_("Matched %d files")
All plurals should be translated to TFN_("%1% user online", "%1% users online", n) % n...also, all
other parametrized strings should be translated to TF_("parameter %1% %2%") % value1 % value2...
See boost format for more detailed formatting information (and check the mailing list archives for
this list). This means that all calls to tformat should go away as well...I'll wait with the patch
until you get this in order.
> Also is this the right place to mention bugs ?
Generally only if they come with great detail or a proposed fix...
> i.e. the icons on the tabs under Wine kind of screw up. Top tab row they are fine, but on all other tab rows, the icons are a lot lower than they should be.
That's a wine bug if it doesn't happen on windows...I've noticed it too...
/J
|
