From: Michael J. <mrm...@ho...> - 2008-01-14 15:14:48
|
>> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all o= thers in that area don't have the ampersand, so should that one or not ? I = would think not, as "&Remove" is used on buttons and i think it's just been= reused, and over looked. So i left this one unchanged. > Add & to the other ones as well if it's a menu... Okay, i'll leave them for the moment, until i can think off good accelerato= rs for the other ones, as it'll help finding some right click menu's in fut= ure. :) > I guess it should wipe both in case it's a directory and not wipe in the = other cases, but I've never > used adl so I wouldn't know =3D) I'll play with Full Path, to see if it uses Filesize then. If not, might a= s well be wiped from that one as well. > I noticed though that CTSTRING is used in the wrong places often - it sho= uld only be used when a > LPCTSTR is needed (raw c pointer to string), so first try T_, and if that= gives compile errors use > CT_...in other words, if the method being called takes a tstring, use T_ = and not CT_... hehe, now you said that, i'm glad i've not got around to doing any CTSTRING= S yet. Compiler errors are a good way to see if it needs it or not. In my= current working copy i used compiler errors to see which files can have th= e ResouceManager.h include deleted. (i failed at moving the ones from the l= ast patch to a different directory, so now my working copy has half submitt= ed and half not submitted changes :P). > On a separate note; should it be pothead, mikejj or Michael Jones that ge= ts credited? I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead. = I've also been meaning to ask if the "Pothead" in the About Box and changel= og could be changed to MikeJJ for a while, but was waiting for the right ti= me to ask ;) Also from my notes of current working copy, might as well ask this one now: UserInfoBase.h needed #include adding to get rid of these errors: win32\/UserInfoBase.h:96: error: 'Text' has not been declared is that the best thing to include ? as it also works including WinUtil.h thanks MikeJJ _________________________________________________________________ Telly addicts unite! http://www.searchgamesbox.com/tvtown.shtml= |