Re: [dcplusplus-devel] Some more translations

[Jacek S. <arn...@gm...>]

> In HubFrame the column uses "Nick" for "User name".  All the other frames use "User".  Not really to sure about this one, because it works "as is" just thought i should mention it.
I think the difference is that in the hub frame, each line is about a user, so nick says which piece
of information about the user we're displaying in that particular column, whereas in the other
places we happen to use the nick as an simple (and ambiguous) way of identification but conceptually
we want to know who the user is...

> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
Name is fine

> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
As David says, T_ is fine.

> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
Add & to the other ones as well if it's a menu...

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
Without full stops looks better to me if it's a simple one-liner.

> I also noticed weird behaviour in ADLSearch
> When change a entry from File to Directory, it wipes the Min Size, but not the Max Size.
> When change a entry from File to Full path, it leaves both Min Size and Max Size.
> So what is the right behaviour, wiping Min Size in both places, but leaving Max Size.  Wiping both Min Size and Max Size.  Or leaving both ?
I guess it should wipe both in case it's a directory and not wipe in the other cases, but I've never
used adl so I wouldn't know =)


> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
CT_ (which is a new macro: "#define CT_(String) T_(String).c_str()")

I noticed though that CTSTRING is used in the wrong places often - it should only be used when a
LPCTSTR is needed (raw c pointer to string), so first try T_, and if that gives compile errors use
CT_...in other words, if the method being called takes a tstring, use T_ and not CT_...

> 
> thanks MikeJJ

On a separate note; should it be pothead, mikejj or Michael Jones that gets credited?


/J