Re: [dcplusplus-devel] dcplusplus-devel Digest, Vol 5, Issue 9

[Michael J. <mrm...@ho...>]

Thanks for the welcome.  I turned the Digest off now, should be a bit easie=
r to use this mailing list now. :)
=20
>> And to clarify, is it meant to be in English or American (they spell thi=
ngs weird) ?
> Well, personally I'd prefer English, but American unfortunately seems to =
be the standard so I guess
> that's the way to go...
Well it's up to you, i just cannot guarantee spelling things correctly the =
American way.  My English spelling isn't perfect, but at least with it, i k=
now when i've spelt a word wrong, and can look it up.  Not really too much =
off a big issue at the moment, as the only two i've seen spelt "wrong" are =
Colour and Favourites.=20

> Feel free to change anything you like...you're the native speaker, not me=
... =3D)
Okay, thanks for the clarification of what to do with that. :)

>> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should thi=
s stay as Name, or become Hub Name ?
> I say stick with Name. The context makes it clear.
Okay, was just checking because the StringDef name was more detailed than t=
he actual string it went too.

>> Trying to convert the columns in HubFrame.cpp an error came on this line=
, which i wasn't sure how to fix correctly, so i reverted my changes until =
a solution comes up (i have got a backup of it though). (Line 120 in svn694=
).
>> filterType->addValue(TSTRING_I(columnNames[j]));
>>  =20
> TSTRING_I(actual code) is a macro that doesn't take a=20
> ResourceManager::EnumValue...
> Looking at the code, this would probably translate to T_(columnNames[j])

Okay, i'll try with that one tomorrow.  The _I part of the TSTRING_I isn't =
anything to worry about then ? (to be honest i have no idea what the _I rel=
ates too), since i saw another TSTRING_I in a different file and didn't kno=
w what to do with that one either.

>> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all o=
thers in that area don't have the ampersand, so should that one or not ? I =
would think not, as "&Remove" is used on buttons and i think it's just been=
 reused, and over looked.  So i left this one unchanged.
>>  =20
> In case you didn't know, the ampersand causes mnemonics to appear under c=
haracters, and keyboard accelerators to be activated. On later Windows vers=
ions they are hidden by default on buttons, can be shown by pressing the AL=
T key.
> My guess is that all the items on the popup menu are all supposed to have=
 mnemonics.
Yup, that's an really annoying setting, one of the first i change after a w=
indows install.  I just thought the ampersand was used there because of re-=
using stringdefs, since all the rest off the popup's don't use it.  Leaving=
 it in implies that all the other entries in every popup needs one as well.=
 :S

>> In FavHubProperties.cpp the string "Hub address cannot be empty." has a =
fullstop at the end, as you can see.  But since no other strings have this,=
 should it be dropped for consistency, or left, with the intention of more =
missing fullstops being added to other strings in the future ?
> Consistency.
Okay :)

>> And one quick last question for further translations.
>> TSTRING(BLAH) goes to T_("Blah")
>> How should CTSTRING(BLAH) end up ?
>>  =20
> CTSTRING(BLAH) would technically become T_("Blah").c_str() Can't vouch fo=
r its correctness though.
Right, another one to try tomorrow. :)

> Great work!
Thanks :D
_________________________________________________________________
Share what Santa brought you
https://www.mycooluncool.com=