Re: [dcplusplus-devel] Some more translations

[David G. <c0...@cs...>]

You've been busy :)

Michael Jones skrev:
> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
>   
I say stick with Name. The context makes it clear.
> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
>   
TSTRING_I(actual code) is a macro that doesn't take a 
ResourceManager::EnumValue...

Looking at the code, this would probably translate to T_(columnNames[j])
> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
>   
In case you didn't know, the ampersand causes mnemonics to appear under 
characters, and keyboard accelerators to be activated. On later Windows 
versions they are hidden by default on buttons, can be shown by pressing 
the ALT key.

My guess is that all the items on the popup menu are all supposed to 
have mnemonics.

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
>   
Consistency.
> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
>   
CTSTRING(BLAH) would technically become T_("Blah").c_str() Can't vouch 
for its correctness though.

Great work!